chaincfg: update dnsseeds #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testnet-seed.bitcoin.schildbach.de is unresponsive and doesn't return any ips. Bitcoin Core has already removed it and we don't also be getting rid of it as well.
His seeds work well and we don't have any for signet and it's good to replace the lost dns seed on testnet.
seed.bitcoinstats.com doesn't respect filter requests even though it's advertised as it does. Plus it often returns nodes that are unreachable. In my testing over the past week, it's been the most unreliable dns seed and since we have plenty of mainnet seeds, it's better to do away with this. I documented my findings for this in a Bitcoin Core issue: bitcoin/bitcoin#29911
It's the same infrastructure that mempool . space runs on and has been reliable. The same seed is also included in Bitcoin Core as well.
Pull Request Test Coverage Report for Build 8789473541Details
💛 - Coveralls |
|
@guggero does my seed fail if you test it with this script? https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/check-dnsseeds.py If not, which dig command did you use? The seed can return IPv4 and IPv6 records and can be reached via IPv4 and IPv6. Is one of there permutations not working, or all of them? (I'm seeing some issues as well from my end, so looking into it) Update: mainnet seed should be fixed now |
|
I just did a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To summarize:
Removed two seeds:
testnet-seed.bitcoin.schildbach.de(testnet),seed.bitcoinstats.com(mainnet).One from schildbach.de is completely unreachable and is also removed in Core. bitcoinstats.com seed is reachable but returns bad results. Documented at bitcoin/bitcoin#29911
Added seeds from Sjors on all three networks.
Added seed from Wiz on mainnet.
I can separate the commits out into different PRs if desired